OP-162 #comment Prototype for Pagination #time 2d #in-review Please review my work #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-review Please review my work
mwithi
changed the title
mwithi
changed the base branch from
master
to
OP-162-create-a-prototype-for-pagination
|
Hi guys, since we have new a new layout in the code and also a new default branch, is it possibile to rebase the work onto |
mwithi
changed the base branch from
OP-162-create-a-prototype-for-pagination
to
develop
|
Superseded by (rebase onto |
ArnaudFonzam
pushed a commit
to ArnaudFonzam/openhospital-gui
that referenced
this pull request
Feb 28, 2024
* Commented useless methods * Removed no longer existing parameters from javadoc * More explanatory comments although the logic seems uselsess * OP-207 #comment fixed AUTOMATICLOT behavior #time 2h * Rearranged lot validation logic * Changed fields position * Fixed lot creation when LOTWITHCOST=no * Added missing testIoNewAutomaticDischargingMovementDifferentLots
ArnaudFonzam
pushed a commit
to ArnaudFonzam/openhospital-gui
that referenced
this pull request
Feb 28, 2024
* Adding profession and marital status fields * OP-171 Added new fields HGT, Diuresis and Bowel (informatici#66) * Re-mapped Examination module with immutable nullable types * Set all values to 'int' except UoM (String) and steps (double). * SAT_MAX deprecated (it is always 100) * HEIGHT_STEP default set to 1 (cm) * PatientExamination refactoring and settings * Fixed UoM: removed user defined UoM and adopted SI (Kg for the Weight and meter for the Height) * Renamed some DB fields names * Porting script for previous data * Moved getBMIdescription() method to Manager * Fixed table name cases * OP-172 laboratory 'undefined' default material (informatici#67) * Fixed Laboratory demo data * OP-173 new dicom features (informatici#68) * Enabled FileSystemDicomManager to Spring (@component) * Removed useless constructor's argument * Enabled JPG and JPEG formats * Added method for SeriesNumber exist check * Fixing DICOM libraries and dependencies * First version of JPEG compatibility in DICOM module * Added utility FileTools for retrieving information from filesystem * Added new Dialog upon dicom/images loading * OP-143: "patient profession" and "marital status" fields (informatici#33) (informatici#76) * OP-140 fix library clibwrapper_jiio (informatici#80) * remove useless boundless repository (informatici#84) * OP-207 automaticlot not working (informatici#93) * Adopted a subset of ICD10 for it, en and fr languages (informatici#89) * Updated OH-core artifact version * removed duplicated dependencies * OP-194 provides more understandable, localized, set of values for operation results * new 'dicom.max.size' property TODO: - possibility to add images to the same series - handle big size images Co-authored-by: aalsabag <[email protected]> Co-authored-by: Alessandro Domanico <[email protected]> Co-authored-by: giuseppe.sorge <[email protected]> Co-authored-by: Paolo <[email protected]> Co-authored-by: Xavier <[email protected]>
ArnaudFonzam
pushed a commit
to ArnaudFonzam/openhospital-gui
that referenced
this pull request
Feb 28, 2024
* OP-171 #comment added UoM to Saturation parameter #time 30min * Re-mapped Examination module with immutable nullable types * Set all values to 'int' except UoM (String) and steps (double). - SAT_MAX deprecated (it is always 100) - HEIGHT_STEP default set to 1 (cm) * PatientExamination refactoring and settings - Fixed UoM: removed user defined UoM and adopted SI (Kg for the Weight and meter for the Height) - Renamed some DB fields names - Porting script for previous data * OP-171 #comment added Remove methods * Moved getBMIdescription() method to Manager * OP-171 #comment Added new fields HGT, Diuresis and Bowel * Included temporary step_XX in dockerfile * Update .travis.yml Debuggin docker * Debugging docker * Debugging Docker * Debugging Docker-Compose * Fixed table name cases * Removing debugger * Rename step_XX_examination_changes.sql to step_60_examination_changes.sql Op 172 vezo 3 laboratory default material (informatici#67) * Fixed Laboratory demo data * OP-172 #comment Added 'undefined' default material Op 173 vezo 4 new dicom features (informatici#68) * Enabled FileSystemDicomManager to Spring (@component) * Removed useless constructor's argument * Enabled JPG and JPEG formats * Added method for SeriesNumber exist check * Fixing DICOM libraries and dependencies * First version of JPEG compatibility in DICOM module * Added utility FileTools for retrieving information from filesystem * Added new Dialog upon dicom/images loading TODO: - possibility to add images to the same series - handle big size images (IndexOutOfBoundsException) Updated OH-core artifact version Upload changelog Fixed step_61 removed duplicated dependencies Fixed step_61 ADWA_6_print labels buttons added (informatici#73) * fixed pom.xml error Co-authored-by: nicola punzi <[email protected]> Op 207 automaticlot not working (informatici#93) * Commented useless methods * Removed no longer existing parameters from javadoc * More explanatory comments although the logic seems uselsess * OP-207 #comment fixed AUTOMATICLOT behavior #time 2h * Rearranged lot validation logic * Changed fields position * Fixed lot creation when LOTWITHCOST=no * Added missing testIoNewAutomaticDischargingMovementDifferentLots "first commit" - add lot information ward to ward ADWA_13_Lot_information_at_the_wards_level: added ward to ward lot information Fixed some tests TODO: - improved MovementWard validationsts with check on lot - fix remaining tests - verify that all movements between wards are consistent added AUTOMATICLOTWARD_TOWARD option and multiple discharge ward to added script Primary key MDSRWRD_LT_ID_A Fixed script and added comments Cosmetic changes to the code Fixed MovementWard tests added choose lot in rectify fixed bug implementation rectify Add some cleaning and refactoring TODO: missing javadocs Fixed some TODOs: simplified methods and added javadoc Finalized script step number Removed duplicated files from rebase Added missing method Fixed JPA mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype Description:
The prototype for pagination involves changes in core and gui. OPD has been used for this prototype. The following screenshots shows the changes accordingly. Kindly review the changes and update accordingly.
Screenshots can be found from JIRA page.
https://openhospital.atlassian.net/browse/OP-162