Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Zuul Logging job #113

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Merge Zuul Logging job #113

wants to merge 13 commits into from

Conversation

ayefimov-1
Copy link
Contributor

@ayefimov-1 ayefimov-1 commented Jul 3, 2024

Merge Logging job changes into Master

Depends-On: #123
Depends-On: #124
#Depends-On: #118

Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some pieces that should be taken out, I think.

I suggest you start by creating a new PR that just adds the common tasks in their own role.
After that, create a PR for the test_logging role (with Depends-On the common_task PR) and then the zuul job (you can reuse this PR) (with a Depends-On on the test_logging PR).
The job won't run on the first two PRs, but the test result from this PR (i.e. "the zuul PR") will be valid for both the "common_tasks PR" and the "test_logging role" PR

ci/logging_tests_local.yml Outdated Show resolved Hide resolved
ci/logging_tests_local.yml Outdated Show resolved Hide resolved
roles/telemetry_logging/README.md Outdated Show resolved Hide resolved
roles/telemetry_logging/README.md Outdated Show resolved Hide resolved
roles/telemetry_logging/defaults/main.yml Outdated Show resolved Hide resolved
.zuul.yaml Outdated Show resolved Hide resolved
ci/run_playbooks_logging.yml Outdated Show resolved Hide resolved
ci/vars-logging-test.yml Outdated Show resolved Hide resolved
ci/vars-logging-test.yml Outdated Show resolved Hide resolved
roles/qe_common/tasks/services_tests.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ayefimov-1 ayefimov-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made updates suggested and associated changes needed.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1b0c0c692c4b4ce5bd342521b556b123

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 12s
functional-tests-on-osp18 FAILURE in 1h 11m 01s
functional-logging-tests-osp18 FAILURE in 1h 10m 08s

ci/logging_tests_ctlplane.yml Outdated Show resolved Hide resolved
ci/logging_tests_ctlplane.yml Outdated Show resolved Hide resolved
changed_when: false


- name: "RHOSO-12754"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, the custom_logger does not look at play names to find the test ids and therefore determine what to log.
It definitely looks at tasks.
The logger MIGHT look at blocks and report pass/fail if the block name has an ID in it.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c31500c78aa243329da4f5edb570f4c1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 57s
functional-tests-on-osp18 FAILURE in 1h 08m 54s
functional-logging-tests-osp18 FAILURE in 1h 09m 56s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/21a4344a3a7b40e2931b4eb1bce91314

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 00s
functional-tests-on-osp18 FAILURE in 1h 26m 03s
functional-logging-tests-osp18 FAILURE in 1h 11m 33s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/177f9dd6e06547faabd000c2302ea3b2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 18s
functional-tests-on-osp18 FAILURE in 1h 08m 37s
functional-logging-tests-osp18 FAILURE in 1h 08m 16s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/32877f52508944ecb877af82800c0a98

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 58s
functional-tests-on-osp18 FAILURE in 1h 11m 42s
functional-logging-tests-osp18 FAILURE in 1h 07m 34s

@ayefimov-1 ayefimov-1 closed this Jul 10, 2024
@ayefimov-1
Copy link
Contributor Author

made lots of changes and will submit new PR.

@elfiesmelfie elfiesmelfie reopened this Jul 15, 2024
@elfiesmelfie
Copy link
Collaborator

Reopening for testing

Copy link

This change depends on a change that failed to merge.

Changes #123, #124 are needed.

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 124,b385de899a6550c566fad7f8a2b6f06f8dbd0bf8

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 113,474a140cb7841a0e7cb2f7f334cc25948cc7ba91

@elfiesmelfie elfiesmelfie changed the base branch from master to alexy_logging2 August 7, 2024 17:49
@elfiesmelfie elfiesmelfie changed the base branch from alexy_logging2 to master August 7, 2024 17:50
@elfiesmelfie
Copy link
Collaborator

elfiesmelfie commented Aug 7, 2024

I rebased this branch against master.
Zuul should take care of checking out the changes from alexy_logging2 branch/PR#123 due to the Depends-on

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9cc04896a584e57b8dad887f4f161bf

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 46s
functional-tests-on-osp18 FAILURE in 1h 07m 06s
functional-logging-tests-osp18 FAILURE in 24m 05s

Copy link

This change depends on a change that failed to merge.

Change #118 is needed.

@elfiesmelfie
Copy link
Collaborator

recheck

@elfiesmelfie
Copy link
Collaborator

I rebased this against the branch for PR#118 to avoid Zuul complaining

Copy link

This change depends on a change that failed to merge.

Change #118 is needed.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c83054825344e6b92fbca4cf36fbd82

openstack-k8s-operators-content-provider FAILURE in 6m 39s
⚠️ functional-logging-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@elfiesmelfie
Copy link
Collaborator

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3775baa77de04fbd9e173618a9f3814f

openstack-k8s-operators-content-provider FAILURE in 9m 16s
⚠️ functional-logging-tests-osp18 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@elfiesmelfie
Copy link
Collaborator

recheck

@elfiesmelfie
Copy link
Collaborator

I need to update this to get the logs in the right place. They are currently not showing, but I think that's because of the recently merged updates to the autoscaling tests that also updates the custom_logger and report-result .

ayefimov-1 and others added 4 commits August 15, 2024 16:00
Add a job that runs the telemetry_logging and common roles against the
openstack cloud.
Separate plays target compute and control nodes
The logging plugins we use need all the tests to run in order to report properly.
Adding ignore_errors to the plays that run the tests allows all the tests to run even when one fails.

Also added verbosity to the ansible config to get more info about the failing tests
@elfiesmelfie elfiesmelfie marked this pull request as draft August 19, 2024 12:23
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aed3b61014404517aff7df849f4cd656

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 12s
functional-logging-tests-osp18 FAILURE in 1h 25m 52s


pod_test_id: "RHOS0-12672"
pod_status_str: "Running"
pod_nspace: openstack-operators
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the qe_common role, the corresponding tasks expect "ns" to be defined, not "pod_namespace"

Copy link

This change depends on a change that failed to merge.

Change #123 is needed.

Copy link

softwarefactory-project-zuul bot commented Aug 19, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2da3c9b316b4dd7bb1790f4b37c2f3c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 43s
functional-logging-tests-osp18 FAILURE in 1h 44m 56s

(elfiesmelfie): this failed due to a deployment failure, not a test failure

@elfiesmelfie
Copy link
Collaborator

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f22267ec8e8a40be9c32e6b275a307d3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 18s
functional-logging-tests-osp18 FAILURE in 1h 14m 08s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1209b7abab04e22bdd4ab1abf05ef02

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 19s
functional-logging-tests-osp18 FAILURE in 1h 07m 02s

KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}"
PATH: "{{ cifmw_path }}"
vars:
pod_test_id: "RHOSO-12752"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the format for these vars should be updated to match the format used by the endpoints.

e.g.
[namespace,pod,status]

That way, multiple plays are not needed.
Same feedback applies to anything that has multiple namespaces

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cc53c6c861da4c6dbab4a007a952f71b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 57s
functional-logging-tests-osp18 FAILURE in 1h 04m 43s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants