Add pod tests to logging job #149
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e5f0a1ca93354e8bb492982c7bf1956f ✔️ feature-verification-tests-noop SUCCESS in 4s |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Add a job that runs the telemetry_logging role against an openstack cloud.
elfiesmelfie
force-pushed
the
efoley_add_pod_test_to_logging
branch
from
d71212d
to
430932f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b565e21c63d545bb83e8a246d14c1dd5 ✔️ feature-verification-tests-noop SUCCESS in 4s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2a39a3f214ba43369d393cf073e9826a ✔️ feature-verification-tests-noop SUCCESS in 4s |
roles/common/tasks/main.yml
Outdated
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| - name: "Verify pod - {{ common_pod_test_id }}" | |||
There was a problem hiding this comment.
This test id should be elsewhere. need to check the compute logging playbook [1]
There was a problem hiding this comment.
The reason why the test_id shouldn't be here is because the include_tasks task will pass as long as the task file exists.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/07574782ba7c4e7fb7cd65507b5dbcb5 ✔️ feature-verification-tests-noop SUCCESS in 5s |
roles/common/tasks/pod_tests.yml
Outdated
| - podinstance.stdout_lines | length == 0 | ||
| changed_when: false | ||
|
|
||
| - name: Check terminated pod {{ common_pod_test_id }} |
There was a problem hiding this comment.
@ayefimov-1 What is the purpose of this second task? It looks like it is repeating the previous test
It might also be mis-named?
Is this just supposed to be getting more information on the pod by name?
If it is there for more information, then I think we can make it optional to run (only run of the pod exists, and don't let this failures effect the test run) since it is informational and not a test
There was a problem hiding this comment.
The goal of this test is to validate the pods existence and status.
Line 12 is misnamed and should be called "Check Pod Status {{ common_pod_test_id }}". If this test fails then either there is a bug or that code changed. I was validating the logging tests and few weeks ago and saw that some tests were failing due to code changes.
There was a problem hiding this comment.
The first tasks is filtering on status.
If the second take is trying to check status, then the first task should not filter on the status.
To leave the first tasks as-is renders the second unnecessary.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5eafe951099446acb1c0ca3da555d4bf ✔️ feature-verification-tests-noop SUCCESS in 4s |
elfiesmelfie
force-pushed
the
efoley_add_pod_test_to_logging
branch
from
f1c18a6
to
ebbef2f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/da74084f1ffa4ed8a14f40b982a292e9 ✔️ feature-verification-tests-noop SUCCESS in 4s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e6d0af9220b4c7595101996672cb90e ✔️ feature-verification-tests-noop SUCCESS in 7s |
| # vars: | ||
| # - <vars from above> | ||
|
|
||
| - name: "Verify logging pods are running in openshift-logging" |
There was a problem hiding this comment.
These are passing except for logging-loki-gateway, which has two instances, so the second task fails because there are \n in the pod name.
| ansible.builtin.import_role: | ||
| name: common | ||
|
|
||
| - name: "Verify logging pods are running in minio-dev" |
There was a problem hiding this comment.
this is passing
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8b5275c352cb4c06b0fd827cccd149b2 ✔️ feature-verification-tests-noop SUCCESS in 4s |
It looks like the functional tests job failed for different reasons to the logging job. |
|
I'll sync this to master and disable the test-operator run. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5a7bb2480ce549ca844a50cf18fe8d11 ✔️ feature-verification-tests-noop SUCCESS in 4s |
The failing job is unrelated to the change and needs to be debugged separately. |
|
recheck |
The test ID will also appear in all subsequent task included by the include_task task, I think. It's been a while since I checked in. |
| - podinstance.stdout_lines | length != 1 | ||
| changed_when: false | ||
|
|
||
| - name: Check pod {{ common_pod_test_id }} |
There was a problem hiding this comment.
Once the custom_logger is merged, we can go back in and rename these tasks.
The new task name format will be:
name: |
<prefix> <task_name>
<test-id>
| @@ -0,0 +1,121 @@ | |||
| --- | |||
| - name: "Verify logging projects, endpoints, credentials, nodes, pods, services, manifests and subscriptions" | |||
There was a problem hiding this comment.
we have this block without any tasks , Is that expected ? can you add please some comments.
mgirgisf
force-pushed
the
efoley_add_pod_test_to_logging
branch
from
2f45b42
to
a6a9667
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a432e6fbc47457eadd95fc30970aee3 ✔️ feature-verification-tests-noop SUCCESS in 4s |
mgirgisf
force-pushed
the
efoley_add_pod_test_to_logging
branch
from
a6a9667
to
b5bf96d
Compare
mgirgisf
force-pushed
the
efoley_add_pod_test_to_logging
branch
from
f4b58db
to
d3f2447
Compare
Depends-On: openstack-k8s-operators/openstack-operator#1115