Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create our own token for prometheus-stf SA #623

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Create our own token for prometheus-stf SA #623

merged 1 commit into from
Jul 25, 2024

Conversation

csibbitt
Copy link
Collaborator

@csibbitt csibbitt commented Jul 24, 2024 •
edited
Loading

  • In OCP 4.16, these are no longer created by default

@csibbitt
Create our own token for prometheus-stf SA
97aa182 
* In OCP 4.16, these are no long created by default
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #609 is needed.

@csibbitt
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #609 is needed.

@csibbitt
Copy link
Collaborator Author

recheck

@csibbitt csibbitt mentioned this pull request Jul 24, 2024
Merged
vkmc
vkmc approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix Chris!

@vkmc vkmc merged commit d1bf042 into master Jul 25, 2024
10 checks passed
@vkmc vkmc deleted the csibbitt/STF-1803_create_scrapeconfig_token branch July 25, 2024 08:24
@elfiesmelfie elfiesmelfie restored the csibbitt/STF-1803_create_scrapeconfig_token branch July 26, 2024 12:32
@elfiesmelfie elfiesmelfie deleted the csibbitt/STF-1803_create_scrapeconfig_token branch July 26, 2024 12:36
@elfiesmelfie
Copy link
Collaborator

There's a "needs-backport" label on this PR, however, the scrapeconfig was added in July in #607, which was not backported to stable-1.5.

It looks to me like this doesn't need a backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkmc vkmc vkmc approved these changes

@elfiesmelfie elfiesmelfie Awaiting requested review from elfiesmelfie

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csibbitt @elfiesmelfie @vkmc