Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
tlouisse authored May 21, 2024
1 parent 520de9c commit 1c556cd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/ui/components/core/src/SlotMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ const SlotMixinImplementation = superclass =>
const hasShadowRoot = Boolean(this.shadowRoot);
if (!hasShadowRoot) {
// TODO: throw an error in a breaking release
// eslint-disable no-console
console.error(`[SlotMixin] No shadowRoot was found`);

Check warning on line 138 in packages/ui/components/core/src/SlotMixin.js

View workflow job for this annotation

GitHub Actions / Verify changes

Unexpected console statement

Check warning on line 138 in packages/ui/components/core/src/SlotMixin.js

View workflow job for this annotation

GitHub Actions / Verify changes

Unexpected console statement
}
const registryRoot = supportsScopedRegistry ? this.shadowRoot : document;
Expand Down

0 comments on commit 1c556cd

Please sign in to comment.