fix(form-core): remove name prop from FormControlMixin

ing-bank · May 18, 2024 · 28cb950 · 28cb950
1 parent 22dc57f
commit 28cb950
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/packages/ui/components/form-core/src/FormControlMixin.js b/packages/ui/components/form-core/src/FormControlMixin.js
@@ -34,7 +34,6 @@ const FormControlMixinImplementation = superclass =>
     /** @type {any} */
     static get properties() {
       return {
-        name: { type: String, reflect: true },
         readOnly: { type: Boolean, attribute: 'readonly', reflect: true },
         label: String, // FIXME: { attribute: false } breaks a bunch of tests, but shouldn't...
         labelSrOnly: { type: Boolean, attribute: 'label-sr-only', reflect: true },

diff --git a/packages/ui/components/form-core/src/registration/FormRegisteringMixin.js b/packages/ui/components/form-core/src/registration/FormRegisteringMixin.js
@@ -55,7 +55,7 @@ const FormRegisteringMixinImplementation = superclass =>
 
     /**
      * Converts values provided for the `name` attribute to string type.
-     * Mimicks the native `input` behavior.
+     * Mimics the native `input` behavior.
      * @param {string} newName
      */
     set name(newName) {

diff --git a/packages/ui/components/form-core/types/FormControlMixinTypes.ts b/packages/ui/components/form-core/types/FormControlMixinTypes.ts
@@ -43,10 +43,6 @@ export declare interface HTMLElementWithValue extends HTMLElement {
 export declare class FormControlHost {
   static get styles(): CSSResultArray;
   static get properties(): {
-    name: {
-      type: StringConstructor;
-      reflect: boolean;
-    };
     readOnly: {
       type: BooleanConstructor;
       attribute: string;
@@ -75,7 +71,7 @@ export declare class FormControlHost {
 
   /**
    * The name the element will be registered with to the .formElements collection
-   * of the parent. Also, it serves as the key of key/value pairs in
+   * of the parent. Also, it serves as the keny of key/value pairs in
    *  modelValue/serializedValue objects
    */
   name: string;