chore(root): cleanup and update dependencies

ing-bank · May 13, 2024 · 2d4a3c3 · 2d4a3c3
1 parent 0493a24
commit 2d4a3c3
Show file tree

Hide file tree

Showing 43 changed files with 6,120 additions and 58,006 deletions.
diff --git a/.changeset/big-rings-heal.md b/.changeset/big-rings-heal.md
@@ -0,0 +1,5 @@
+---
+'providence-analytics': minor
+---
+
+cleanup of code and dependencies. Added optimised-glob util, which is a faster, 0-dependency drop-in replacement for globby
diff --git a/.github/workflows/verify.yml → .github/workflows/verify-pr.yml b/.github/workflows/verify.yml → .github/workflows/verify-pr.yml
@@ -11,21 +11,22 @@ jobs:
       - uses: actions/checkout@v2
 
       - name: Sanity check
-        run: node ./scripts/lock-scan.js
+        run: node ./scripts/lock-scan.mjs
 
-      - name: Setup Node 16.x
-        uses: actions/setup-node@v1
+      - name: Setup Node 18.x
+        uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 18.x
+          cache: npm
 
       - name: Install Dependencies
         run: npm install --ci
 
       - name: Lint
         run: npm run lint
 
-      - name: Bundlesize
-        run: npm run bundlesize
+      # - name: Bundlesize
+      #   run: npm run bundlesize
 
   browser-tests:
     name: Browser tests
@@ -34,10 +35,11 @@ jobs:
       - uses: google/wireit@setup-github-actions-caching/v1
       - uses: actions/checkout@v2
 
-      - name: Setup Node 16.x
-        uses: actions/setup-node@v1
+      - name: Setup Node 18.x
+        uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 18.x
+          cache: npm
 
       - name: Install Dependencies
         run: npm install --ci
@@ -47,44 +49,45 @@ jobs:
       - name: Test
         run: npm run test:browser
 
-  node-tests:
-    name: Node tests
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        node-version: [16.x]
-        os: [ubuntu-latest]
-    steps:
-      - uses: google/wireit@setup-github-actions-caching/v1
-      - uses: actions/checkout@v2
+  # node-tests:
+  #   name: Node tests
+  #   runs-on: ${{ matrix.os }}
+  #   strategy:
+  #     matrix:
+  #       node-version: [16.x]
+  #       os: [ubuntu-latest]
+  #   steps:
+  #     - uses: google/wireit@setup-github-actions-caching/v1
+  #     - uses: actions/checkout@v4
+
+  #     - name: Setup Node ${{ matrix.node-version }}
+  #       uses: actions/setup-node@v2
+  #       with:
+  #         node-version: ${{ matrix.node-version }}
+  #         cache: npm
+
+  #     - name: Install Dependencies
+  #       run: npm install --ci --force
+
+  #     - name: Test
+  #       run: npm run test:node
 
-      - name: Setup Node ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
-        with:
-          node-version: ${{ matrix.node-version }}
-
-      - name: Install Dependencies
-        run: npm install --ci
-
-      - name: Test
-        run: npm run test:node
-
-  # Note this is a duplicate of the matrix (so we have 2 1x1 matrices). Up for improvement...
-  node-tests-windows:
+  node-tests:
     name: Node tests
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [16.x]
-        os: [windows-latest]
+        node-version: [16.x, 18.x]
+        os: [ubuntu-latest, windows-latest]
     steps:
       - uses: google/wireit@setup-github-actions-caching/v1
       - uses: actions/checkout@v2
 
       - name: Setup Node ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
+          cache: npm
 
       - name: Install Dependencies
         run: npm install --ci

diff --git a/.lintstagedrc.js b/.lintstagedrc.js
@@ -4,7 +4,6 @@ module.exports = {
   '*.md': [
     'prettier --write',
     "markdownlint --ignore '{.github/**/*.md,.changeset/*.md,**/CHANGELOG.md,packages/ui/_legacy-changelogs/*.md}'",
-    'git add',
   ],
   'package-lock.json': ['node ./scripts/lock-scan.js'],
   '*package.json': absolutePaths => {

diff --git a/docs/components/combobox/src/md-combobox/style/md-ripple.js b/docs/components/combobox/src/md-combobox/style/md-ripple.js
@@ -59,6 +59,7 @@ class MdRipple extends LitElement {
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     this.removeEventListener('mousedown', this.__onRipple);
   }
 

diff --git a/docs/fundamentals/systems/form/validate.md b/docs/fundamentals/systems/form/validate.md
@@ -612,7 +612,7 @@ However, the validation system also supports three non blocking validation feedb
 - **error**: blocking the field from being submitted to the server. For example:
   "Please enter an amount higher than 1000,00 euro."
 - **warning**: something looks wrong, but it is not blocking. For example an optional email input:
-  "Please enter a valid e-mail address in the format "[email protected]"."
+  "Please enter a valid e-mail address in the format `[email protected]`."
 - **info**: shows extra information. For example a message of a scheduled payment planner:
   "Ends on 15/05/2020 after 5 payments."
 - **success**: will only be triggered if there was a Message from one of the above validation types and is now correct. For example: "Ok, correct."

diff --git a/docs/fundamentals/systems/overlays/_configuration-positioning.md b/docs/fundamentals/systems/overlays/_configuration-positioning.md
@@ -99,15 +99,6 @@ export const placementGlobal = () => {
 
 ## popperConfig
 
-/** Viewport configuration. Will be used when placementMode is 'global' \*/
-viewportConfig?: ViewportConfig;
-/** Hides other overlays when multiple are opened (currently exclusive to globalOverlayController) _/
-isBlocking?: boolean;
-/\*\* Will align contentNode with referenceNode (invokerNode by default) for local overlays. Usually needed for dropdowns. 'max' will prevent contentNode from exceeding width of referenceNode, 'min' guarantees that contentNode will be at least as wide as referenceNode. 'full' will make sure that the invoker width always is the same. _/
-inheritsReferenceWidth?: 'max' | 'full' | 'min' | 'none';
-/\*_ Change the default of 9999 _/
-zIndex?: number;
-
 | Prop                   | Description                                                                                                                                                                                                                                                                                                     | Type                               |     |     |     |
 | ---------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------- | --- | --- | --- |
 | placementMode          | Determines the positioning anchor (viewport vs invokerNode/referenceNode)                                                                                                                                                                                                                                       | 'global'\|'local'                  |     |     |     |