Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] incorporate hasChanged in sync updates #1914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[draft] incorporate hasChanged in sync updates #1914

wants to merge 1 commit into from

Conversation

tlouisse
Copy link
Member

  • considers hasChanged function of static get properties for all sync updates in FormatMixin
  • fixes dirty check of dates, so that new Date('2020/10/10') equals new Date('2020/10/10')
  • fixes some behaviors with fomatting erroneous values wrt initial user-input-changed handling

TODO:

  • make all tests run again

closes #1910

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

⚠️ No Changeset found

Latest commit: 6dbf671

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gerjanvangeest gerjanvangeest added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2023
@gerjanvangeest
Copy link
Member

This PR still needs some attention, maybe we can bring it back to live and finalise it soon!
Anybody lending a hand, feel free 💪!

tlouisse
tlouisse commented Apr 4, 2024
View reviewed changes
packages/ui/components/input-date/src/LionInputDate.js
* Change function that returns true if `value` is different from `oldValue`.
* This method is used as the default for a property's `hasChanged` function.
*/
export const notEqual = (value, old) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: in latest lit, we can import this function: https://github.com/lit/lit/blob/main/packages/reactive-element/src/reactive-element.ts#L376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerjanvangeest gerjanvangeest Awaiting requested review from gerjanvangeest gerjanvangeest will be requested when the pull request is marked ready for review gerjanvangeest is a code owner

@narzac narzac Awaiting requested review from narzac narzac will be requested when the pull request is marked ready for review narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias will be requested when the pull request is marked ready for review Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin will be requested when the pull request is marked ready for review okadurin is a code owner

@ryubro ryubro Awaiting requested review from ryubro ryubro will be requested when the pull request is marked ready for review ryubro is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhance dirty check of input-date / input-datepicker
2 participants
@tlouisse @gerjanvangeest