Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select-rich): update WAI ARIA pattern to combobox-select-only #1942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(select-rich): update WAI ARIA pattern to combobox-select-only #1942

wants to merge 1 commit into from

Conversation

gerjanvangeest
Copy link
Member

@gerjanvangeest gerjanvangeest commented Mar 15, 2023 •
edited
Loading

What I did

  1. [select-rich] update WAI ARIA pattern to combobox-select-only
  2. Add docs about why we use a native dialog inside all our overlays

TODO:

  • Full screen reader test to make sure it is an improvement

fix: #1784

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 73e8175

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerjanvangeest
Copy link
Member Author

This change works good in Chrome + Voiceover, Firefox + Voiceover, Edge + NVDA, Firefox + NVDA. But in Safari + Voiceover i get the following:

Old:
image

New:
image

Which isn't an improvement.
So I would say. Wait half a year and check again before merging this PR.

@gerjanvangeest gerjanvangeest added bug Something isn't working a11y Related to A11Y dependencies Pull requests that update a dependency file labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@daKmoR daKmoR Awaiting requested review from daKmoR

@erikkroes erikkroes Awaiting requested review from erikkroes

@ruphin ruphin Awaiting requested review from ruphin

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@whenlit whenlit Awaiting requested review from whenlit

@DannyMoerkerke DannyMoerkerke Awaiting requested review from DannyMoerkerke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a11y Related to A11Y bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[select-rich] Select rich is not programatically identified as a combo box
1 participant
@gerjanvangeest