-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DisabledController to replace the DisabledMixin #2181
Conversation
🦋 Changeset detectedLatest commit: e701bf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @Ramon92, Thanks for this contribution. Can you also add it to the |
Hi @gerjanvangeest |
I'll close this PR due to inactivity. Also on a side node, the |
Apologies, did not find the time after all. |
What I did
A first step to move away from
ClassMixins
on components and use controllersThis should improve debugging and tracking back what methods belongs to which controller/Mixin
Properties are then also set by the component making it clear in code what the properties of the component are and no hidden properties added by
ClassMixins
disabled
propertydisabled
propertyDisabledMixin
to asses the same functionality is still working