Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/providence updates #2278

Merged
merged 8 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/big-rings-heal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'providence-analytics': minor
---

- Added `optimised-glob` util: a drop-in replacement for globby. It's faster, smaller and has zero dependencies
- Added `fs-adapter` util, allowing to provide a virtual fs instead of the default
- BREAKING: Cleanup of code and dependencies, removing deprecated cli commands
File renamed without changes.
73 changes: 73 additions & 0 deletions .github/workflows/verify-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
name: Verify changes

on: pull_request

jobs:
verify:
name: Verify changes
runs-on: ubuntu-latest
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- name: Sanity check
run: node ./scripts/lock-scan.mjs

- name: Setup Node 18.x
uses: actions/setup-node@v4
with:
node-version: 18.x
cache: npm

- name: Install Dependencies
run: npm install --ci

- name: Lint
run: npm run lint

# - name: Bundlesize
# run: npm run bundlesize

browser-tests:
name: Browser tests
runs-on: ubuntu-latest
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- name: Setup Node 18.x
uses: actions/setup-node@v4
with:
node-version: 18.x
cache: npm

- name: Install Dependencies
run: npm install --ci

- uses: microsoft/playwright-github-action@v1

- name: Test
run: npm run test:browser

node-tests:
name: Node tests
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [16.x, 18.x]
os: [ubuntu-latest, windows-latest]
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: npm

- name: Install Dependencies
run: npm install --ci --force

- name: Test
run: npm run test:node
93 changes: 0 additions & 93 deletions .github/workflows/verify.yml

This file was deleted.

1 change: 0 additions & 1 deletion .lintstagedrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ module.exports = {
'*.md': [
'prettier --write',
"markdownlint --ignore '{.github/**/*.md,.changeset/*.md,**/CHANGELOG.md,packages/ui/_legacy-changelogs/*.md}'",
'git add',
],
'package-lock.json': ['node ./scripts/lock-scan.js'],
'*package.json': absolutePaths => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class MdRipple extends LitElement {
}

disconnectedCallback() {
super.disconnectedCallback();
this.removeEventListener('mousedown', this.__onRipple);
}

Expand Down
2 changes: 1 addition & 1 deletion docs/fundamentals/systems/form/validate.md
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ However, the validation system also supports three non blocking validation feedb
- **error**: blocking the field from being submitted to the server. For example:
"Please enter an amount higher than 1000,00 euro."
- **warning**: something looks wrong, but it is not blocking. For example an optional email input:
"Please enter a valid e-mail address in the format "[email protected]"."
"Please enter a valid e-mail address in the format `[email protected]`."
- **info**: shows extra information. For example a message of a scheduled payment planner:
"Ends on 15/05/2020 after 5 payments."
- **success**: will only be triggered if there was a Message from one of the above validation types and is now correct. For example: "Ok, correct."
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,6 @@ export const placementGlobal = () => {

## popperConfig

/** Viewport configuration. Will be used when placementMode is 'global' \*/
viewportConfig?: ViewportConfig;
/** Hides other overlays when multiple are opened (currently exclusive to globalOverlayController) _/
isBlocking?: boolean;
/\*\* Will align contentNode with referenceNode (invokerNode by default) for local overlays. Usually needed for dropdowns. 'max' will prevent contentNode from exceeding width of referenceNode, 'min' guarantees that contentNode will be at least as wide as referenceNode. 'full' will make sure that the invoker width always is the same. _/
inheritsReferenceWidth?: 'max' | 'full' | 'min' | 'none';
/\*_ Change the default of 9999 _/
zIndex?: number;

| Prop | Description | Type | | | |
| ---------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------- | --- | --- | --- |
| placementMode | Determines the positioning anchor (viewport vs invokerNode/referenceNode) | 'global'\|'local' | | | |
Expand Down
Loading