-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slotmixin): Now throws shadowRoot not found in case of shadowRoot… #2291
Conversation
🦋 Changeset detectedLatest commit: 69150cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Thijs Louisse <[email protected]>
Hello @tlouisse! It was my first contribution to open source,
It created a .changeset/odd-poets-grow.md
|
Hi @Dozom
It's a good practice to attach a changeset entry to a commit(
This is done automatically in a separate pipeline (@changeset/cli generates the changelog based on the changeset files: https://github.com/changesets/changesets?tab=readme-ov-file) |
Hi @tlouisse |
Yes, looks good. Thanks for the contribution! |
… equals to null
What I did