Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add files more than once doesn't overwrite anymore #2308

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

ryubro
Copy link
Contributor

@ryubro ryubro commented Jun 27, 2024

What I did

  1. Fixed a bug that when user adds files more than once, the model value is overwritten by the last addition but the file list grows, adding the last addition to the existing list
    • Example: User added two files, a and b in a file dialog, then added another file c opening a file dialog once more. The file list would have a, b, c but the model value would be c. After the fix, the model value also would be a, b, c.
    • Tested on both dialog and drag & drop

  • Fixing an issue when we upload the same file, the model value gets empty.

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 5917423

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@ryubro ryubro marked this pull request as draft June 27, 2024 07:07
@ryubro ryubro marked this pull request as ready for review June 27, 2024 07:12
@ryubro ryubro force-pushed the fix/input-file-modelvalue branch from e64eea9 to f3729c7 Compare June 27, 2024 07:14
@ryubro
Copy link
Contributor Author

ryubro commented Jun 27, 2024

Done Fixing an issue when we upload the same file, the model value gets empty.

@ryubro ryubro force-pushed the fix/input-file-modelvalue branch from f3729c7 to d75976a Compare June 27, 2024 08:33
@ryubro ryubro merged commit 2015fa7 into master Jun 27, 2024
7 checks passed
@ryubro ryubro deleted the fix/input-file-modelvalue branch June 27, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants