-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add files more than once doesn't overwrite anymore #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryubro
requested review from
tlouisse,
gerjanvangeest,
narzac,
Knorgias and
okadurin
as code owners
June 27, 2024 07:06
🦋 Changeset detectedLatest commit: 5917423 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryubro
force-pushed
the
fix/input-file-modelvalue
branch
from
June 27, 2024 07:14
e64eea9
to
f3729c7
Compare
Done |
ryubro
force-pushed
the
fix/input-file-modelvalue
branch
from
June 27, 2024 08:33
f3729c7
to
d75976a
Compare
gerjanvangeest
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
a
andb
in a file dialog, then added another filec
opening a file dialog once more. The file list would havea
,b
,c
but the model value would bec
. After the fix, the model value also would bea
,b
,c
.