fix: form validators check and disabled prop #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardikpthv
requested review from
tlouisse,
gerjanvangeest,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: 5eb7fc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Let me know if i need to add changeset :) |
okadurin
reviewed
Oct 31, 2024
Please do :) |
tlouisse
reviewed
Oct 31, 2024
hardikpthv
force-pushed
the
fix/validator-n-formcontrol-mixin
branch
2 times, most recently
from
e10721b
to
81e54f4
Compare
hardikpthv
force-pushed
the
fix/validator-n-formcontrol-mixin
branch
from
81e54f4
to
a5b2c2d
Compare
hardikpthv
force-pushed
the
fix/validator-n-formcontrol-mixin
branch
from
c90a6ef
to
6e8aae6
Compare
hardikpthv
commented
Nov 6, 2024
hardikpthv
force-pushed
the
fix/validator-n-formcontrol-mixin
branch
from
6275469
to
faf21c9
Compare
tlouisse
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
validatorNameandtypeto check validator instance