feat(dialog): add is-alert-dialog option #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: d0c4c31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gerjanvangeest
force-pushed
the
feat/alertdialog
branch
4 times, most recently
from
060dd38 to
f388b28
Compare
gerjanvangeest
force-pushed
the
feat/alertdialog
branch
from
f388b28 to
d0c4c31
Compare
tlouisse
reviewed
Jan 17, 2025
|
|
||
| ```js preview-story | ||
| export const alertDialog = () => { | ||
| const placementModeGlobalConfig = { placementMode: 'global', isAlertDialog: true }; |
There was a problem hiding this comment.
Maybe the best practice here would be to combine it with withModalDialog()
tlouisse
reviewed
Jan 17, 2025
| <demo-el-using-overlaymixin .config="${placementModeGlobalConfig}"> | ||
| <button slot="invoker">Click me to open the alert dialog!</button> | ||
| <div slot="content" class="demo-overlay"> | ||
| Hello! You can close this notification here: |
There was a problem hiding this comment.
As application of the role is dependent on content, maybe the content should reflect this a bit more.
Suggested change
| Hello! You can close this notification here: | |
| Are you sure you want to perform this action? |
tlouisse
reviewed
Jan 17, 2025
| > | ||
| ⨯ | ||
| </button> | ||
| </div> |
There was a problem hiding this comment.
Maybe add a "No" and "Yes" button here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did