Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/core): rerender direct host child with right slot attr when root is switched #2448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlouisse
Copy link
Member

@tlouisse tlouisse commented Jan 16, 2025

  // Assume we had: { template: myBool ? html`<div id=a></div>` : html`<span id=b></span>`, renderAsDirectHostChild: true }
  // If myBool started as true, <div id=a></div> would be rendered in first render above, A slot would be applied...
  // However, when myBool changes to false, the <span id=b></span> would be rendered instead...
  // We need to make sure that this "replaced root" gets the slot applied as well

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: ba4aa60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tlouisse tlouisse force-pushed the feat/slotMixinRerenderDirectHostChild branch from 066dd23 to ba4aa60 Compare January 17, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant