Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHAPRFECV speedup for bigger use-cases and some simple refactoring. #252

Merged
merged 79 commits into from
Apr 23, 2024

Conversation

ReinierKoops
Copy link

@ReinierKoops ReinierKoops commented Mar 21, 2024

This PR depends on the PR to be accepted: #248


This cleanup removes some more unused code and simplifies parts of our implementations. It should allow for a boost in performance for bigger use-cases, although minimal.

Also fix:

@ReinierKoops
Copy link
Author

Also replace scorer with sklearn implementation #245

Copy link
Collaborator

@adri0 adri0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/feature_elimination/test_feature_elimination.py Outdated Show resolved Hide resolved
@ReinierKoops ReinierKoops requested review from adri0 and removed request for anilkumarpanda and PaulZhutovsky April 23, 2024 07:19
@ReinierKoops ReinierKoops merged commit c1a6889 into main Apr 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants