Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update catboost requirement #254

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Update catboost requirement #254

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f34b48
Update catboost requirement from <1.2 to <1.3
dependabot[bot] Mar 26, 2024
6b87ea3
Update pyproject.toml
Mar 26, 2024
9995045
Update pyproject.toml
Mar 26, 2024
664b2f0
Update pyproject.toml
Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ dev = [
"isort>=5.12.0",
"codespell>=2.2.4",
"ruff>=0.2.2",
"lightgbm>=3.3.0",
# https://github.com/catboost/catboost/issues/2371
"catboost>=1.2 ; python_version != '3.8'",
"catboost<1.2 ; python_version == '3.8'",
"xgboost>=1.5.0",
"scipy>=1.4.0",
]
docs = [
"mkdocs>=1.5.3",
Expand All @@ -72,16 +78,9 @@ docs = [
"mkdocstrings>=0.24.1",
"mkdocstrings-python>=1.8.0",
]
extras = [
"lightgbm>=3.3.0",
# https://github.com/catboost/catboost/issues/2371
"catboost<1.2 ; python_version == '3.8'",
"catboost>=1.1 ; python_version != '3.8'",
"xgboost>=1.5.0",
"scipy>=1.4.0",
]
Copy link
Collaborator

@adri0 adri0 Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this is extra dependency option with all packages seems not very useful. But in the future it could be nice having one optional dependency for each algorithm. If the user is just interested in using probatus with lightgbm without having to install the others sounds like a fair use case.


# Separating these allow for more install flexibility.
all = ["probatus[dev,docs,extras]"]
all = ["probatus[dev,docs]"]

[tool.setuptools.packages.find]
exclude = ["tests", "notebooks", "docs"]
Expand Down Expand Up @@ -130,4 +129,4 @@ extend_skip = ["__init__.py", "docs"]
skip = "**.egg-info*"

[tool.black]
line-length = 120
line-length = 120