fix selection of best categories bucketers.py #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when encoding_method == "ordered" the features are ordered based on the proportion of events in the target variable in ascending order. Ideally, we would like to keep the categories with highest proportion of events separately, and those with lowest volume of events, then to be dropped by doing normalized_counts = normalized_counts[-self.max_n_categories:] we ensure to keep the top frequent categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when encoding_method == "ordered" the features are ordered based on the proportion of events in the target variable in ascending order.
Ideally, we would like to keep the categories with highest proportion of events separately, and those with lowest volume of events, then to be dropped
by doing
normalized_counts = normalized_counts[-self.max_n_categories:]
we ensure to keep the top frequent categories