Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] okr_management: Migration to 17.0 #165

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions okr_management/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
21 changes: 21 additions & 0 deletions okr_management/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
'name': 'Okr',
'version': "17.0.1.0.0",
'category': 'Projects & Services',
'sequence': 14,
'summary': '',
'author': 'ADHOC SA',
'website': 'www.adhoc.com.ar',
'license': 'AGPL-3',
'images': [
],
'depends': [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregar dependencia minimo a modulo 'base'

],
'data': [
'security/ir.model.access.csv',
'views/okr_management_views.xml',
],
'installable': True,
'auto_install': False,
'application': False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'application': True

}
2 changes: 2 additions & 0 deletions okr_management/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import okr_management
from . import okr_key_result
27 changes: 27 additions & 0 deletions okr_management/models/okr_key_result.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
from odoo import models, fields, api
from odoo.exceptions import UserError

class OkrKeyResult(models.Model):
_name = 'okr.key.result'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usar "." cuando es un submodelo, "_" cuando es parte del nombre (por ej "key_result")

_description = 'Okr Key Result'

name = fields.Char()
description = fields.Text()
objective =fields.Text()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El objective, deberia ser un objective_id relacionado al modelo okr.objective

user_ids = fields.Many2one(
'res.users',
)
progress= fields.Integer(
compute='_compute_okr_progress',
store = False,
)
Comment on lines +14 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aca son necesarios 3 campos:
Target que es el puntaje a obtener (esta mas abajo, eso esta bien)
Resultado (es el resultado parcial, este falta)
Progress esta bien y es computado pero creo que lo estas usando como el campo anterior (Resultado)

importance = fields.Integer()#importancia dentro del kr
target = fields.Integer()#objetivo esperado

@api.depends('peso', 'target')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltan dependencias a resultado (campo que no existe)

La dependdencia a peso esta bien pero el campo no existe

def _compute_okr_progress(self):
#mejorar codigo
prog = 0
for rec in self:
if rec.importance and rec.target:
prog = rec.importance
Comment on lines +22 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisar formula del excel para implementar aca

25 changes: 25 additions & 0 deletions okr_management/models/okr_management.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
from odoo import models, fields, api
from odoo.exceptions import UserError

class OkrManagement(models.Model):
_name = 'okr.management'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto tendira que ser el modelo okr.objective

_description = 'Okr management'

name = fields.Char()
description = fields.Text()
user_ids = fields.Many2many(
comodel_name='res.users',
)
progress= fields.Integer(
compute='_compute_okr_progress',
store = False,
)
okr_type = fields.Selection(
selection=[
('commitment', 'Commitment'),
('inspiracional', 'Inspiracional'),
],
)
result = fields.Float()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result deberia ser computado y tener en cuenta el progreso que tienen los key result

action_plan = fields.Text()
comments = fields.Text()
3 changes: 3 additions & 0 deletions okr_management/security/ir.model.access.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_okr_management,access_okr_management,model_okr_management,base.group_user,1,1,1,1
access_okr_key_result,access_okr_key_result,model_okr_key_result,base.group_user,1,1,1,1
47 changes: 47 additions & 0 deletions okr_management/views/okr_management_views.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<record id="view_okr_management_tree" model="ir.ui.view">
<field name="name">okr.management.tree</field>
<field name="model">okr.management</field>
<field name="arch" type="xml">
<tree>
<field name="name"/>
<field name="progress"/>
<field name="action_plan" />
</tree>
</field>
</record>

<record id="view_okr_management_form" model="ir.ui.view">
<field name="name">okr.management.form</field>
<field name="model">okr.management</field>
<field name="arch" type="xml">
<form>
<field name="name"/>
<field name="progress"/>
<field name="action_plan"/>
<field name="okr_type"/>
</form>
</field>
</record>

<record id="view_okr_management_search" model="ir.ui.view">
<field name="name">okr.management.search</field>
<field name="model">okr.management</field>
<field name="arch" type="xml">
<search>
<field name="name"/>
</search>
</field>
</record>

<record id="action_okr_management" model="ir.actions.act_window">
<field name="name">okr management</field>
<field name="res_model">okr.management</field>
<!-- <field name="target">current</field> -->
<field name='view_mode'>tree,form</field>
</record>

<menuitem id="menu_okr_management" sequence="100" action="action_okr_management"/>

</odoo>