[ADD] *: pre-commit #237
Open
[ADD] *: pre-commit #237
+897
−662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lef-adhoc
force-pushed
the
18.0-miscellaneous-pre-commit
branch
from
c919999 to
2a0bcfc
Compare
vib-adhoc
requested changes
Feb 4, 2025
There was a problem hiding this comment.
@lef-adhoc Hola Fran, te dejo algunos comentarios para que ajustes cuando hagas el rebase. Seguro el de la versión de python lo tenías en mente, pero lo dejo también a modo de recordatorio!
| [](https://coveralls.io/r/ingadhoc/?branch=18.0) | ||
| [](https://codeclimate.com/github/ingadhoc/) | ||
|
|
||
| # miscellaneous |
There was a problem hiding this comment.
Acá el nombre debería ser "ADHOC Miscellaneous Modules" para no hacer cambios. Esto se establece con el coppier en la vriable 'name'. Podrías cambiarlo? Ejecutando coppier nuevamente o cambiándolo directamente acá y en .copier-answers.yml
| # Keep in sync with .github/workflows/pre-commit.yml | ||
| default_language_version: | ||
| python: python3.10 |
There was a problem hiding this comment.
Recordar cambiar la versión de python a solo python3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.