Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n_ar_edi_ux: Add test_update_from_afip #447

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

mem-adhoc
Copy link
Contributor

No description provided.

@roboadhoc
Copy link
Contributor

@mem-adhoc mem-adhoc force-pushed the 16.0-t-41723-mem branch 4 times, most recently from ef26e8a to 663b812 Compare September 23, 2024 18:49
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
@mem-adhoc mem-adhoc force-pushed the 16.0-t-41723-mem branch 2 times, most recently from 03213b6 to 2fcf9b8 Compare September 24, 2024 16:59
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
l10n_ar_edi_ux/tests/test_update_from_afip.py Outdated Show resolved Hide resolved
@mem-adhoc
Copy link
Contributor Author

@zaoral Kathy, I already made the changes you aske me for!

def setUp(self):
super().setUp()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is not change to the setup method then we do not need to define it, only need to define it if we are modifying things

def testmonotributo(self):
"""Actualizamos un contacto del tipo monotributo"""

"""Chequeamos que no hay actividades ni impuestos creados"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double docstring?

wiz.update_selection()

self.assertEqual(contacto.name, 'Marjorier, Lamara', "Name after the update from afip must change")
#Chequeamos que las actividades e impuestos se hayan creado con la actualizacion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after #, if not will be a pylint error

import odoo.tests.common as common
from odoo.exceptions import UserError

class TestUpdateFromAfip(common.TransactionCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need double line betwseen imports and class definition, if not pylint error pop up

@zaoral
Copy link
Contributor

zaoral commented Sep 25, 2024

superseded by #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants