Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Credentiallookup and HTTPS pom #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matt2005
Copy link

Fixes Credential lookup when editing a job.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry

matt2005 and others added 2 commits January 20, 2022 18:47
This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Signed-off-by: Jonathan Leitschuh <[email protected]>

Co-authored-by: Jonathan Leitschuh <[email protected]>
* Fix: credentialId was not retained in config

Fixes ingenieux#4

Steps to reproduce:

1. specify credentialId in configure page
2. save
3. reload page
4. credentialId has gone, but should still be there

* Fix: no getter found for repositoryName

Exception is thrown when trying to export the configuration of this
plugin using the Jenkins CasC plugin.

* Fix: make it possible to use CodeCommitHelper for a Shared Library

Co-authored-by: Tobia De Koninck <[email protected]>
@aldrinleal
Copy link
Member

Awesome thanks! I'll look into that over the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants