fix: fzaar denom

[ALPAC-4]

Fix fZAAR cosmos denom

Summary by CodeRabbit

• Chores
  • Updated Zaar testnet configuration files
  • Removed 0x prefix from hexadecimal addresses in asset and fee token configurations
  • Maintained consistent representation of asset denomination across configuration files

[coderabbitai]

Walkthrough

The pull request involves updating the assetlist.json and chain.json files for the Zaar testnet. The primary change is the removal of the "0x" prefix from hexadecimal addresses in the denom and base fields related to the "Fake ZAAR Token". This modification ensures consistency in the representation of the asset's denomination across these configuration files, specifically for the EVM-based token address.

Changes

File	Change Summary
testnets/zaar/assetlist.json	Removed "0x" prefix from hexadecimal address in denom and base fields for Fake ZAAR Token
testnets/zaar/chain.json	Updated denom in fee_tokens array by removing "0x" prefix from hexadecimal address

Possibly related PRs

• feat: add zaar #246: Changes directly related to the Fake ZAAR Token's denom and base fields
• fix: fix zaar evm chain id #248: Updates to evm_chain_id in Zaar testnet configuration

Suggested reviewers

• simcheolhwan

Poem

🐰 A Rabbit's Ode to Hex Addresses 🔧

No more "0x" to clutter the way,
Clean addresses dance and play,
Zaar's token, sleek and bright,
Stripped of prefix, pure delight!
Hop along, configuration clear! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 554e579 and 0857d69.

📒 Files selected for processing (2)

• testnets/zaar/assetlist.json (2 hunks)
• testnets/zaar/chain.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Cloudflare Pages: registry-initiation-1

🔇 Additional comments (2)

testnets/zaar/assetlist.json (1)

9-9: Verify EVM address format consistency.

The removal of "0x" prefix from the EVM address in denom and base fields while keeping it in the address field appears intentional. However, let's verify this is the expected format for these fields.

Also applies to: 19-19

✅ Verification successful

EVM address format is consistent with codebase convention

The removal of "0x" prefix from EVM addresses in denom and base fields aligns with the established format across all testnet configurations. This format is consistently used in zaar, yominet, and culinaris networks.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of EVM address format across the codebase

# Search for other occurrences of EVM addresses in denom/base fields
echo "Checking denom/base fields format:"
rg '"denom":\s*"evm/0x[a-fA-F0-9]{40}"' || echo "No denoms with 0x prefix found"
rg '"base":\s*"evm/0x[a-fA-F0-9]{40}"' || echo "No base with 0x prefix found"

echo -e "\nChecking current format:"
rg '"denom":\s*"evm/[a-fA-F0-9]{40}"' || echo "No denoms without 0x prefix found"
rg '"base":\s*"evm/[a-fA-F0-9]{40}"' || echo "No base without 0x prefix found"

Length of output: 1203

testnets/zaar/chain.json (1)

17-17: Verify fee token configuration.

The change to remove "0x" prefix from the fee token denom is consistent with the changes in assetlist.json. However, since this affects fee configuration, we should verify this change doesn't impact fee processing.

✅ Verification successful

Fee token configuration format is correct

The removal of "0x" prefix from the EVM address in fee token denom is consistent with other EVM fee token configurations in the codebase. Found multiple instances following the same format pattern: evm/<address> without "0x" prefix.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistency of fee token configuration

# Check for any documentation or code that validates fee token format
echo "Checking for fee token format documentation:"
rg -i "fee.*token.*format|denom.*format" . || echo "No explicit format documentation found"

# Check for similar fee token configurations in other chains
echo -e "\nChecking other chain configurations:"
fd -e json -x jq -r '.fees.fee_tokens[].denom | select(startswith("evm/"))' {} \; || echo "No other EVM fee tokens found"

Length of output: 2980

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.