Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create db for kvindexer in AppCreator #50

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: create db for kvindexer in AppCreator #50

merged 1 commit into from
Jul 18, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jul 16, 2024

create db for kvindexer inside of AppCreator() in order to be easily customized

NOTE: breaking changes in app.toml due to bumped kvindexer

@Vritra4 Vritra4 requested a review from beer-1 July 16, 2024 06:50
@Vritra4 Vritra4 self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 57.42%. Comparing base (b9484ca) to head (79098e3).

Files Patch % Lines
cmd/minitiad/root.go 0.00% 19 Missing ⚠️
app/encoding.go 33.33% 2 Missing ⚠️
app/app.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   57.90%   57.42%   -0.48%     
==========================================
  Files          16       16              
  Lines        1734     1750      +16     
==========================================
+ Hits         1004     1005       +1     
- Misses        689      704      +15     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit ad24e6a into main Jul 18, 2024
4 of 6 checks passed
@beer-1 beer-1 deleted the inject-kvdb branch July 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants