Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update slinky => connect/v2 #67

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: update slinky => connect/v2 #67

merged 1 commit into from
Sep 25, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Sep 25, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 requested a review from a team as a code owner September 25, 2024 08:26
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.73%. Comparing base (7c93065) to head (8a3f885).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files          39       39           
  Lines        3207     3207           
=======================================
  Hits         2076     2076           
  Misses        956      956           
  Partials      175      175           
Files with missing lines Coverage Δ
app/genesis.go 91.66% <100.00%> (ø)
app/keepers/keepers.go 98.59% <100.00%> (ø)
app/keepers/keys.go 93.54% <ø> (ø)
app/modules.go 100.00% <100.00%> (ø)

@beer-1 beer-1 merged commit a0c1dbd into main Sep 25, 2024
8 checks passed
@beer-1 beer-1 deleted the feat/connect-v2 branch September 25, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant