Add logger to logical decoding singleton

inngest · Oct 8, 2024 · cd89c86 · cd89c86
1 parent fbe5747
commit cd89c86
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pkg/decoder/pg_logical_v1.go b/pkg/decoder/pg_logical_v1.go
@@ -12,8 +12,9 @@ import (
 	"github.com/jackc/pgx/v5/pgtype"
 )
 
-func NewV1LogicalDecoder(s *schema.PGXSchemaLoader) Decoder {
+func NewV1LogicalDecoder(s *schema.PGXSchemaLoader, log *slog.Logger) Decoder {
 	return v1LogicalDecoder{
+		log:       log,
 		schema:    s,
 		relations: make(map[uint32]*pglogrepl.RelationMessage),
 	}
@@ -81,7 +82,9 @@ func (v v1LogicalDecoder) Decode(in []byte, cs *changeset.Changeset) (bool, erro
 
 	default:
 		// Unsupported message - log and carry on.
-		v.log.Debug("unsupported message type in v1 decoder", "msg_type", msgType.String())
+		if v.log != nil {
+			v.log.Debug("unsupported message type in v1 decoder", "msg_type", msgType)
+		}
 	}
 
 	return false, nil

diff --git a/pkg/replicator/pgreplicator/pg.go b/pkg/replicator/pgreplicator/pg.go
@@ -100,7 +100,7 @@ func New(ctx context.Context, opts Opts) (PostgresReplicator, error) {
 		opts:      opts,
 		conn:      replConn,
 		queryConn: pgxc,
-		decoder:   decoder.NewV1LogicalDecoder(sl),
+		decoder:   decoder.NewV1LogicalDecoder(sl, opts.Log),
 		log:       opts.Log,
 	}, nil
 }