Make serve config configurable on spring boot adapter (#56)

* expose serve config to be configurable * update version for adapter --------- Co-authored-by: Darwin D Wu <[email protected]>
inngest · Jul 18, 2024 · aab3c42 · aab3c42
1 parent 757d6f8
commit aab3c42
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/inngest-spring-boot-adapter/VERSION b/inngest-spring-boot-adapter/VERSION
@@ -1 +1 @@
-0.0.3
+0.0.4
diff --git a/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestConfiguration.java b/inngest-spring-boot-adapter/src/main/java/com/inngest/springboot/InngestConfiguration.java
@@ -15,9 +15,10 @@ public abstract class InngestConfiguration {
     protected abstract Inngest inngestClient();
 
     @Bean
-    protected CommHandler commHandler(@Autowired Inngest inngestClient) {
-        // TODO: Add missing configuration
-        ServeConfig serveConfig = new ServeConfig(inngestClient);
-        return new CommHandler(functions(), inngestClient, serveConfig, frameworkName);
+    protected abstract ServeConfig serve(@Autowired Inngest inngestClient);
+
+    @Bean
+    protected CommHandler commHandler(@Autowired Inngest inngestClient, @Autowired ServeConfig serve) {
+        return new CommHandler(functions(), inngestClient, serve, frameworkName);
     }
 }
diff --git a/inngest-spring-boot-demo/src/main/java/com/inngest/springbootdemo/DemoConfiguration.java b/inngest-spring-boot-demo/src/main/java/com/inngest/springbootdemo/DemoConfiguration.java
@@ -21,7 +21,12 @@ public HashMap<String, InngestFunction> functions() {
     }
 
     @Override
-    public Inngest inngestClient() {
+    protected Inngest inngestClient() {
         return new Inngest("spring_demo");
     }
+
+    @Override
+    protected ServeConfig serve(Inngest inngestClient) {
+        return new ServeConfig(inngestClient);
+    }
 }
diff --git a/inngest-spring-boot-demo/src/test/java/com/inngest/springbootdemo/DemoTestConfiguration.java b/inngest-spring-boot-demo/src/test/java/com/inngest/springbootdemo/DemoTestConfiguration.java
@@ -35,6 +35,11 @@ protected Inngest inngestClient() {
         return new Inngest("spring_test_demo");
     }
 
+    @Override
+    protected ServeConfig serve(Inngest client) {
+        return new ServeConfig(client);
+    }
+
     @Bean
     protected CommHandler commHandler(@Autowired Inngest inngestClient) {
         ServeConfig serveConfig = new ServeConfig(inngestClient);