Create ktor adapter for SDK
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
KiKoS0
added a commit
that referenced
this pull request
Feb 25, 2024
I think someone with better spring boot knowledge can shape a better interface to create the inngest client + CommHandler but this is already better than manually creating a singleton and having everything in a random controller. Note: It might be better to not have a second adapter package and instead have these spring boot helpers as a feature variant. But I'll see how it goes with this PR first: #27 I'm also adding a way to build the Inngest client configuration possibly through a Builder pattern targeted to the specific environment that the user wants to use.
KiKoS0
added a commit
that referenced
this pull request
Feb 25, 2024
I think someone with better spring boot knowledge can shape a better interface to create the inngest client + CommHandler but this is already better than manually creating a singleton and having everything in a random controller. Note: It might be better to not have a second adapter package and instead have these spring boot helpers as a feature variant. But I'll see how it goes with this PR first: #27 I'm also adding a way to build the Inngest client configuration possibly through a Builder pattern targeted to the specific environment that the user wants to use.
KiKoS0
added a commit
that referenced
this pull request
Feb 25, 2024
I think someone with better spring boot knowledge can shape a better interface to create the inngest client + CommHandler but this is already better than manually creating a singleton and having everything in a random controller. Note: It might be better to not have a second adapter package and instead have these spring boot helpers as a feature variant. But I'll see how it goes with this PR first: #27 I'm also adding a way to build the Inngest client configuration possibly through a Builder pattern targeted to the specific environment that the user wants to use.
KiKoS0
added a commit
that referenced
this pull request
Feb 25, 2024
I think someone with better spring boot knowledge can shape a better interface to create the inngest client + CommHandler but this is already better than manually creating a singleton and having everything in a random controller. Note: It might be better to not have a second adapter package and instead have these spring boot helpers as a feature variant. But I'll see how it goes with this PR first: #27 I'm also adding a way to build the Inngest client configuration possibly through a Builder pattern targeted to the specific environment that the user wants to use.
darwin67
force-pushed
the
darwin/ktor-routes
branch
from
ee4de8a to
c41ece9
Compare
KiKoS0
added a commit
that referenced
this pull request
Feb 25, 2024
* Add spring-boot-adapter project & InngestController * Remove the singleton in favor of bean injecting the inngest config I think someone with better spring boot knowledge can shape a better interface to create the inngest client + CommHandler but this is already better than manually creating a singleton and having everything in a random controller. Note: It might be better to not have a second adapter package and instead have these spring boot helpers as a feature variant. But I'll see how it goes with this PR first: #27 I'm also adding a way to build the Inngest client configuration possibly through a Builder pattern targeted to the specific environment that the user wants to use.
darwin67
force-pushed
the
darwin/ktor-routes
branch
from
c41ece9 to
6c2e1d3
Compare
darwin67
requested review from
djfarrelly,
jpwilliams and
tonyhb
as code owners
darwin67
changed the title
core packagektor adapter for SDK
KiKoS0
reviewed
Feb 25, 2024
albertchae
reviewed
Feb 25, 2024
| @@ -15,6 +15,8 @@ dependencies { | |||
| implementation("com.fasterxml.jackson.core:jackson-databind:2.16.1") | |||
| implementation("com.squareup.okhttp3:okhttp:4.12.0") | |||
|
|
|||
| implementation("io.ktor:ktor-server-core:2.3.5") | |||
There was a problem hiding this comment.
hm, I know you were looking at optional dependencies but I think it's a bit clearer if the framework specific adapters are wrappers outside of a generic inngest-core. Not sure what's more common in Kotlin/Java ecosystem though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide pre-defined routes for
ktor, and also move the comm handler and client in there to hide implementation details from the user.ktorhas been added as a dependency for the SDK, but it should probably be an optional dependency based on enabled feature.Reference: https://docs.gradle.org/current/userguide/feature_variants.html?_gl=1*1shpi06*_ga*MTUzOTI5MTY2NS4xNzA4ODQ3NjEw*_ga_7W7NC6YNPT*MTcwODg0NzYxMC4xLjAuMTcwODg0NzYxMC42MC4wLjA