Use configured baseUrl and eventKey for sending events #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NO_EVENT_KEY_SET` matches the JS SDK https://github.com/inngest/inngest-js/blob/1b9f101ca6cd310e429cebcf8bceaf2faf309624/packages/inngest/src/components/Inngest.ts#L312 https://github.com/inngest/inngest-js/blob/1b9f101ca6cd310e429cebcf8bceaf2faf309624/packages/inngest/src/helpers/consts.ts#L151 Alternatively, we could use `test` like https://github.com/darwin67/inngest-ex/blob/5785538f13d4c1d7c970c65f83eefd89a0d8de09/lib/inngest/config.ex#L115-L117
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
KiKoS0
approved these changes
Feb 26, 2024
darwin67
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_EVENT_KEY_SETmatches the JS SDKhttps://github.com/inngest/inngest-js/blob/1b9f101ca6cd310e429cebcf8bceaf2faf309624/packages/inngest/src/components/Inngest.ts#L312
https://github.com/inngest/inngest-js/blob/1b9f101ca6cd310e429cebcf8bceaf2faf309624/packages/inngest/src/helpers/consts.ts#L151
Alternatively, we could use
testlike https://github.com/darwin67/inngest-ex/blob/5785538f13d4c1d7c970c65f83eefd89a0d8de09/lib/inngest/config.ex#L115-L117