Implement rateLimit configuration #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
requested review from
djfarrelly,
darwin67,
jpwilliams and
tonyhb
as code owners
albertchae
force-pushed
the
albert/inn-3332-implement-rate-limit
branch
from
8d88a7f to
c925bd6
Compare
KiKoS0
approved these changes
Sep 12, 2024
| Thread.sleep(500); | ||
| String event3 = InngestFunctionTestHelpers.sendEvent(client, "test/rateLimit").getIds()[0]; | ||
|
|
||
| Thread.sleep(2000); |
There was a problem hiding this comment.
Should we increase the duration similar to idempotency #85?
RateLimitedFunctionIntegrationTest > testFunctionIsRateLimited() FAILED
java.lang.ArrayIndexOutOfBoundsException: 0
at com.inngest.springbootdemo.EventRunsResponse.first(EventRunsResponse.java:14)
at com.inngest.springbootdemo.RateLimitedFunctionIntegrationTest.testFunctionIsRateLimited(RateLimitedFunctionIntegrationTest.java:32)There was a problem hiding this comment.
good idea, increased the two 2000ms waits to 4000ms
There was a problem hiding this comment.
Adjusted all the times again based on https://www.inngest.com/docs/guides/rate-limiting#how-rate-limiting-works
Very similar to throttle implementation in #66
albertchae
force-pushed
the
albert/inn-3332-implement-rate-limit
branch
from
c925bd6 to
ba3587a
Compare
albertchae
commented
Sep 13, 2024
Comment on lines
+23
to
+25
| // Rate limit test function is limited to 2 over 6 seconds. Based on the simplistic description of GCRA in | ||
| // https://www.inngest.com/docs/guides/rate-limiting#how-rate-limiting-works | ||
| // we need to sleep at least 3 seconds here for the second event not to get rate limited |
There was a problem hiding this comment.
This test was buggy before instead of just being flaky. After reading the documentation at https://www.inngest.com/docs/guides/rate-limiting#how-rate-limiting-works, I adjusted the sleep times for the test to hopefully run more robustly.
albertchae
commented
Sep 13, 2024
| // Sleep at least 6 seconds for the rate limit bucket to be completely cleared | ||
| Thread.sleep(6000); | ||
|
|
||
| // Rate limit should only allow the first 2 events to run |
There was a problem hiding this comment.
the function config was mismatched with this comment until now 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add rateLimit configuration per https://github.com/inngest/inngest/blob/0ac11f2c312c066e517e53749052dd89fd2926ba/docs/SDK_SPEC.md?plain=1#L586-L606
Very similar to throttle implementation in #66
Checklist
Related