Clean up remaining issues with hyperd.log generation

innobi · Aug 21, 2024 · fa79af6 · fa79af6
1 parent 88f940c
commit fa79af6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/pantab/_reader.py b/src/pantab/_reader.py
@@ -59,7 +59,8 @@ def frames_from_hyper(
 
     table_names = []
     with tempfile.TemporaryDirectory() as tmp_dir, tab_api.HyperProcess(
-        tab_api.Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU
+        tab_api.Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU,
+        parameters={"log_config": ""},
     ) as hpe:
         tmp_db = shutil.copy(source, tmp_dir)
         with tab_api.Connection(hpe.endpoint, tmp_db) as connection:

diff --git a/src/pantab/reader.cpp b/src/pantab/reader.cpp
@@ -437,7 +437,7 @@ static auto ReleaseArrowStream(void *ptr) noexcept -> void {
 auto read_from_hyper_query(const std::string &path, const std::string &query)
     -> nb::capsule {
   const std::unordered_map<std::string, std::string> params = {
-      {"log_config", ""}};
+      {"log_config", ""}, {"default_database_version", "4"}};
   const hyperapi::HyperProcess hyper{
       hyperapi::Telemetry::DoNotSendUsageDataToTableau, "", std::move(params)};
   hyperapi::Connection connection(hyper.getEndpoint(), path);

diff --git a/tests/test_writer.py b/tests/test_writer.py
@@ -289,7 +289,8 @@ def test_can_write_wkt_as_geo(tmp_hyper):
 
     pt.frame_to_hyper(df, tmp_hyper, table="test", geo_columns=["geography"])
     with tab_api.HyperProcess(
-        tab_api.Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU
+        tab_api.Telemetry.DO_NOT_SEND_USAGE_DATA_TO_TABLEAU,
+        parameters={"log_config": ""},
     ) as hyper:
         with tab_api.Connection(
             hyper.endpoint, tmp_hyper, tab_api.CreateMode.CREATE_IF_NOT_EXISTS