Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repin all possible vCPUs, not just ones in use #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Repin all possible vCPUs, not just ones in use #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions igvm/kvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,15 +174,17 @@ def set_vcpus(hypervisor, vm, domain, num_cpu):
def _live_repin_cpus(domain, props, max_phys_cpus):
"""Adjusts NUMA pinning of all VCPUs."""
num_nodes = props.num_nodes
for vcpu, mask in enumerate(domain.vcpuPinInfo()):
mask = list(mask)
# Set interleaving NUMA pinning for each VCPU up to the maximum
max_vcpus = props.max_cpus
# We used to iterate over the output of domain.vcpuPinInfo() here but
# it only showed the pinning for the current CPUs, not the maximum.
# It ended up that when migrating VMs from a host with more CPUs to a host
# with less CPUs, the VM couldn't have the amount of vCPUs increased, as the
# pinning still had the old (higher) amount of CPUs.
for vcpu in range(max_vcpus):
mask = []
# Set interleaving NUMA pinning for each vCPU up to the maximum
for pcpu in range(0, max_phys_cpus):
mask[pcpu] = (pcpu % num_nodes == vcpu % num_nodes)
# And disable all above the threshold
# (Useful when migrating to a host with less CPUs)
for pcpu in range(max_phys_cpus, len(mask)):
mask[pcpu] = False
mask.append(pcpu % num_nodes == vcpu % num_nodes)
domain.pinVcpu(vcpu, tuple(mask))


Expand Down