Skip check for permission to change for related_via attrs #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofrezo
force-pushed
the
dk_fix_acl_check_related_attrs
branch
from
bbc74aa to
be2fd25
Compare
Attributes on servertypes which are configured to get their value from another servertype (related_via) should be excluded from the permission check to change them because the actual change takes place on the target servertype and is also checked there. Thus the check would be redundant and annoying because you have to whitelist the attributes in two places in ACLs.
kofrezo
force-pushed
the
dk_fix_acl_check_related_attrs
branch
2 times, most recently
from
0bebbdf to
3fcef5c
Compare
YannikSc
pushed a commit
to YannikSc/serveradmin
that referenced
this pull request
Apr 19, 2024
) Attributes on servertypes which are configured to get their value from another servertype (related_via) should be excluded from the permission check to change them because the actual change takes place on the target servertype and is also checked there. Thus the check would be redundant and annoying because you have to whitelist the attributes in two places in ACLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes on servertypes which are configured to get their value from another servertype (related_via) should be excluded from the permission check to change them because the actual change takes place on the target servertype and is also checked there.
Thus the check would be redundant and annoying because you have to whitelist the attributes in two places in ACLs.