Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "_" in hostname #354

Merged
merged 1 commit into from
May 15, 2024
Merged

Allow "_" in hostname #354

merged 1 commit into from
May 15, 2024

Conversation

brainexe
Copy link
Member

@brainexe brainexe commented Apr 17, 2024

Needed e.g. for domains like "_acme-challenge.example.com" or "21293504._domainkey.chat.example.com"

Needed e.g. for domains like "_acme-challenge.example.com"
@brainexe brainexe changed the title WIP: Allow trailing "_" in hostname attribute. WIP: Allow "_" in hostname attribute. Apr 17, 2024
@brainexe brainexe requested a review from kofrezo May 14, 2024 11:55
@brainexe brainexe changed the title WIP: Allow "_" in hostname attribute. Allow "_" in hostname attribute. May 14, 2024
@brainexe brainexe changed the title Allow "_" in hostname attribute. Allow "_" in hostname May 14, 2024
@kofrezo kofrezo merged commit 4c055ac into main May 15, 2024
5 checks passed
@kofrezo kofrezo deleted the hostname_regexp branch May 15, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants