Allow changes if permitted by app or user #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the current behavior so that a change must be permitted by the applications ACLs or the users ACLs (if there is no application) but no longer the application and the owner of the application. This is the wanted behavior because we either commit changes from the Servershell where we want to evaluate the permissions of the logged in user or from the Adminapi where we want to evaluate the permissions of the application. We do not care about the owner of the application for the evaluation as applications should be stand alone. The ownership is relevant for disabling all applications when a user gets disabled and of course to keep track of who uses the application. The old behavior has historical reasons that are no longer met.
brainexe
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the current behavior so that a change must be permitted by the
applications ACLs or the users ACLs (if there is no application) but no
longer the application and the owner of the application.
This is the wanted behavior because we either commit changes from the
Servershell where we want to evaluate the permissions of the logged in
user or from the Adminapi where we want to evaluate the permissions of
the application. We do not care about the owner of the application for
the evaluation as applications should be stand alone.
The ownership is relevant for disabling all applications when a user
gets disabled and of course to keep track of who uses the application.
The old behavior has historical reasons that are no longer met.