Retry signing the request if too slow #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where the cryptographic operation to sign the request takes unusually long. One example is when using a hardware such as the YubiKey which is busy signing other stuff. The Serveradmin server is pretty strict and would reject these as expired for security reasons. To gracefully handle temporary congestion in the signing we log an error and retry the operation up to Settings.tries.
kofrezo
commented
Jun 27, 2024
| f'Signing the requests took {time_spent_signing} seconds! ' | ||
| 'Serveradmin would reject this request. Maybe your signing ' | ||
| f'soft-/hardware is congested ? Retry {retry}/{Settings.tries}.') | ||
| return _build_request(endpoint, get_params, post_params, retry+1) |
There was a problem hiding this comment.
Question to my reviewers: Should we consider a random sleep here ?
There was a problem hiding this comment.
I think for now we can leave it without sleeps
v0devil
approved these changes
Jul 1, 2024
| f'Signing the requests took {time_spent_signing} seconds! ' | ||
| 'Serveradmin would reject this request. Maybe your signing ' | ||
| f'soft-/hardware is congested ? Retry {retry}/{Settings.tries}.') | ||
| return _build_request(endpoint, get_params, post_params, retry+1) |
There was a problem hiding this comment.
I think for now we can leave it without sleeps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the cryptographic operation to sign the request takes unusually long. One example is when using a hardware such as the YubiKey which is busy signing other stuff.
The Serveradmin server is pretty strict and would reject these as expired for security reasons.
To gracefully handle temporary congestion in the signing we log an error and retry the operation up to Settings.tries.