Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clarify strings #121

Merged
merged 2 commits into from
Jan 16, 2025
Merged

chore: Clarify strings #121

merged 2 commits into from
Jan 16, 2025

Conversation

KobeW50
Copy link
Collaborator

@KobeW50 KobeW50 commented Jan 16, 2025

No description provided.

@KobeW50
Copy link
Collaborator Author

KobeW50 commented Jan 16, 2025

For the Watch history patch, perhaps the patch description can explain why it is useful.

Current description: Adds an option to change the domain of the watch history or check its status.

Maybe it can be something along the lines of:

"Adds a settings menu for diagnosing and fixing issues with [the] watch history."

@inotia00 inotia00 changed the title Strings chore: Clarify strings Jan 16, 2025
@inotia00
Copy link
Owner

ReVanced's Check watch history domain name resolution patch checks if the domain s.youtube.com can be reached (diagnoses), and if not, displays a dialog.

RVX's Watch history patch does not diagnose if the domain s.youtube.com can be reached.

Instead, the settings menu simply states If you use a DNS or VPN, watch history may not work.

@inotia00 inotia00 merged commit 44600d9 into inotia00:dev Jan 16, 2025
@KobeW50 KobeW50 deleted the dev branch January 19, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants