refactor(elements|ino-tab-bar): accessible ino-tab-bar #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasHeimGalindo
temporarily deployed
to
github-pages
GitHub Actions
Inactive
janivo
changed the title
janivo
requested changes
Nov 16, 2023
Comment on lines
60
to
63
| buttonElement.setAttribute('aria-selected', isSelected.toString()); | ||
| if (panelId) { | ||
| buttonElement.setAttribute('aria-controls', panelId); | ||
| } |
There was a problem hiding this comment.
These lines assume the internal structure of the <ino-tab> component and therefore have too much knowledge. As soon as we do some refactoring of our tab component, we won't really realize that we might be breaking things.
That's why I would propose to implement these lines as properties of the <ino-tab> component. They could be named like our other accessibility props (e.g. a11ySelected and a11yControls) and just set these values to the internal button element. We also should write a disclaimer in the comments that these properties are managed by the ino-tab-bar component.
This way, the ino-tab-bar uses only the public API of our ino-tab.
janivo
requested changes
Dec 7, 2023
janivo
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1002
Note on Accessibility Implementations for Tab Panels
Our
ino-tabandino-tab-barcomponents focus on providing the tab and the tablist functionality. We do not control or provide the tab panels, as these are part of the user's content implementation. To support accessibility, I added apanelIdproperty to theino-tabcomponent. This enables users to link each tab with its corresponding content panel for accessibility purposes, following WAI-ARIA practices. However, the actual implementation of tab panels and their accessibility attributes (role="tabpanel",aria-labelledby, etc.) is under the user's control.