refactor(elements/ino-fab): migrate stencil e2e tests to spec test #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
# Conflicts: # packages/storybook/src/stories/test-utils.ts
janivo
requested changes
Mar 14, 2024
Comment on lines
12
to
20
| test('should not open the dial by click', async () => { | ||
| const { width, height } = await inoFabSet.boundingBox(); | ||
| await inoFabSet.click(); | ||
| const { width: openWidth, height: openHeight } = | ||
| await inoFabSet.boundingBox(); | ||
|
|
||
| expect(openWidth).toEqual(width); | ||
| expect(openHeight).toBeGreaterThan(height * 2); | ||
| }); |
There was a problem hiding this comment.
Instead of checking for the height, can't we just check for the visibility of the FABs?
Pseudocode:
expect(fabs).not.toBeVisible()
await inoFabSet.click()
expect(fabs).toBeVisible()
|
Is there a specific reason, why you disabled the shadow dom? |
With shadow dom i was not able to test the components in jest. |
# Conflicts: # .github/workflows/test.yml
janivo
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1258
Proposed Changes
ino-fabandino-fab-set