Minor fixes (#115)

inovex · Aug 11, 2020 · 77ed156 · 77ed156
1 parent cd93f86
commit 77ed156
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/docs/developing.md b/docs/developing.md
@@ -78,8 +78,7 @@ There is also a simple bash script that makes it easier to setup the development
 Installing Calico (or other [CNI network plugins](https://kubernetes.io/docs/concepts/cluster-administration/networking/#how-to-implement-the-kubernetes-networking-model)) for example:
 
 ```bash
-# actually we don't need the rbac rules since minikube has rbac deactivated per default
-kubectl apply -f https://docs.projectcalico.org/v3.5/getting-started/kubernetes/installation/hosted/kubernetes-datastore/calico-networking/1.7/calico.yaml
+kubectl apply -f https://docs.projectcalico.org/manifests/calico.yaml
 ```
 
 ## Use the local Docker daemon
@@ -121,7 +120,7 @@ sudo systemctl status containerd
 Now we can build locally the new runner image:
 
 ```bash
-docker build -t "$(minikube ip):5000/illuminatio-runner:dev" -f illuminatio-runner.dockerfile .
+docker build -t "$(minikube ip):5000/illuminatio-runner:dev" .
 ```
 
 And if you run the following command you should see the new image `docker images`.

diff --git a/src/illuminatio/manifests/runner-daemonset.yaml b/src/illuminatio/manifests/runner-daemonset.yaml
@@ -40,6 +40,8 @@ spec:
           value: {runtime}
         - name: CONTAINER_RUNTIME_ENDPOINT
           value: {cri_socket}
+        command:
+        - illuminatio-runner
         args:
         - --verbosity={log_level}
         image: {image}

diff --git a/tests/assets/containerd.yaml b/tests/assets/containerd.yaml
@@ -40,6 +40,8 @@ spec:
           value: containerd
         - name: CONTAINER_RUNTIME_ENDPOINT
           value: /var/run/dockershim.sock
+        command:
+          - illuminatio-runner
         args:
           - --verbosity=NOTSET
         image: inovex/illuminatio-runner:dev

diff --git a/tests/assets/containerd_custom_socket.yaml b/tests/assets/containerd_custom_socket.yaml
@@ -40,6 +40,8 @@ spec:
           value: containerd
         - name: CONTAINER_RUNTIME_ENDPOINT
           value: /var/run/containerd/containerd.sock
+        command:
+          - illuminatio-runner
         args:
           - --verbosity=NOTSET
         image: inovex/illuminatio-runner:dev

diff --git a/tests/assets/docker.yaml b/tests/assets/docker.yaml
@@ -40,6 +40,8 @@ spec:
           value: docker
         - name: CONTAINER_RUNTIME_ENDPOINT
           value: /var/run/docker.sock
+        command:
+          - illuminatio-runner
         args:
           - --verbosity=NOTSET
         image: inovex/illuminatio-runner:dev