Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve docker compose deployment documentation (#4561) #4625

Merged
merged 3 commits into from
Nov 20, 2024
Merged

docs: Improve docker compose deployment documentation (#4561) #4625

merged 3 commits into from
Nov 20, 2024

Conversation

Avalancs
Copy link
Contributor

@Avalancs Avalancs commented Nov 15, 2024 •
edited
Loading

Description

Improve docker compose deployment documentation #4561

Schwehn42
Schwehn42 reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @Avalancs! Looks good to me, regarding the headings could you just change the "#" to "##" and "##" to "###" to be in line with the other files? Thanks :)

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Nov 18, 2024
Schwehn42
Schwehn42 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution ✌️

@Schwehn42 Schwehn42 enabled auto-merge November 20, 2024 12:32
@Schwehn42 Schwehn42 removed the Changes Requested Changes requested by the reviewer label Nov 20, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into inovex:main with commit 0de4c36 Nov 20, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schwehn42 Schwehn42 Schwehn42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avalancs @Schwehn42