Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Yellow Contrast & Note Tooltip Improvements #4779

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Resaki1
Copy link
Collaborator

@Resaki1 Resaki1 commented Jan 15, 2025

Description

Improved the color contrast on some elements, especially for the yellow color. Also added/improved some tooltips on the note buttons. Closes #4534.

Changelog

  • Darkened all yellow colors
  • darker colors for numbers and icons
  • removed shadow from vote buttons
  • added tooltips for vote buttons
    • changed tooltip text of disabled buttons to show why they are disabled
  • removed background of delete and unstack note buttons
  • added padding below stacked notes to show the full shadow

Design:
Contrast-issue-yellow.pdf

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check if every single color is correct but all in all it looks great!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During voting, when focusing the remove vote button (using keyboard) both the minus and the count are displayed:
Screenshot 2025-01-16 at 14 33 38

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Jan 16, 2025
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4779.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-bcf4dd0

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-bcf4dd0

Copy link

octomind-dev bot commented Jan 21, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: bcf4dd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Changes requested by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrast Issue with Yellow
2 participants