67 use simplify geom from db #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? - R was out of date on @ALanguillaume's computer What? - Install new R version - Reinstall all packages - Make sure local R profile knows about Pop!_Os
Why? - Simplification already made in database. What? - Remove call to ms_simplify() Issues #67
Why? - Two polygons have invalid geometry in current db version. What? - Add reprex in data exploration vignette Issues #67
|
Closed for #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geometry of catchment
v_basinis no longer simplified in R.This is still not the case for rectangles
v_ice_geoms. Some geometries are invalid.This has been documented in a reprex in
data-raw/aa-a-exploration_data.RmdIssues traitées à garder ouvertes ou en cours :
Checklist: