Avoid creating duplicate events by respecting the UID field #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For events that contain a UID field, use Google Calendar's event "import" feature instead of "insert" to avoid creating duplicates. Note that events with UID populated may still get processed as new/updated events if the SEQUENCE number is also incremented (https://www.kanzaki.com/docs/ical/sequence.html).
This was referenced Aug 25, 2024
Closed
|
Alright, I figured I may not get feedback on the quality of this until after it's released, so I took another look through the changes with a paranoid eye, caught and fixed a couple issues, and added an opt-out flag With that I'm going to go ahead and merge this in a bit if nobody objects. |
dbarnett
commented
Aug 26, 2024
Comment on lines
+1532
to
+1535
| if is_skipped_dupe: | ||
| # TODO: #492 - Offer to force import dupe anyway? | ||
| self.printer.msg( | ||
| f'Skipped duplicate event {event_label}.\n') |
There was a problem hiding this comment.
FYI in my testing the API didn't seem to respect the "sequence" number and still considered the events duplicates.
And another confusing corner case: seems like deleted events can still be considered "duplicates" and skipped.
Those could both be helped if we added more explicit detection and prompted users for how to resolve weird cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For events that contain a UID field, use Google Calendar's event import feature instead of insert to avoid creating duplicates.
Note that events with UID populated may still get processed as new/updated events if the SEQUENCE number is also incremented (https://www.kanzaki.com/docs/ical/sequence.html).
Fixes #492 & #583.