Fix event list lookups returning incorrect events due to pagination #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
force-pushed
the
paginated_events
branch
from
56c4fb7
to
f2116e6
Compare
|
Actually I went ahead and merged partial fix #664 as-is before merging my remaining changes here. Updating commit messages accordingly. |
Ensures that requests using pageToken preserve the same parameters as the initial request to avoid returning non-matching items after the first page.
dbarnett
force-pushed
the
paginated_events
branch
from
f2116e6
to
70d8d6d
Compare
|
Oops, forgot to update the commit message. Oh, well... BTW there were also some test/linter failures from the partial fix that got resolved in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that requests using pageToken preserve the same parameters as the initial request to avoid returning non-matching items after the first page.
Fixes issue mentioned in PR #664.