-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making ard_survey_svycontinuous()
a S3 method
#150
Conversation
ard_survey_svycontinuous()
a S3 method
Unit Tests Summary 1 files 57 suites 9s ⏱️ Results for commit 4419876. |
Unit Tests Summary 1 files 65 suites 10s ⏱️ Results for commit 0beacc7. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 41496a2 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 0beacc7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great Daniel! I'll update the categorical function into an s3 method as well :)
What changes are proposed in this pull request?
Converted
ard_survey_svycontinuous()
to a S3 methodard_continuous.survey.design()
.Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.ard_*()
function was added,set_cli_abort_call()
has been set.ard_*()
function was added and it depends on another package (such as,broom
),is_pkg_installed("broom", reference_pkg = "cardx")
has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cardx (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).