Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

survey one-sample CIs #177

Merged
merged 5 commits into from
Jun 28, 2024
Merged

survey one-sample CIs #177

merged 5 commits into from
Jun 28, 2024

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom", reference_pkg = "cardx") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@ddsjoberg ddsjoberg marked this pull request as ready for review June 28, 2024 04:49
Copy link
Contributor

github-actions bot commented Jun 28, 2024

Unit Tests Summary

  1 files   84 suites   11s ⏱️
 84 tests  57 ✅ 27 💤 0 ❌
242 runs  203 ✅ 39 💤 0 ❌

Results for commit 8cef7d5.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 28, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_survey_categorical_ci 👶 $+0.00$ $+2$ $0$ $0$ $0$
ard_survey_continuous_ci 👶 $+0.00$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_survey_categorical_ci 👶 $+0.01$ ard_survey_categorical_ci_by_
ard_survey_categorical_ci 👶 $+0.00$ ard_survey_categorical_ci_conf.level_
ard_survey_categorical_ci 👶 $+0.63$ ard_survey_categorical_ci_data_
ard_survey_categorical_ci 👶 $+0.00$ ard_survey_categorical_ci_method_
ard_survey_categorical_ci 👶 $+0.03$ ard_survey_categorical_ci_variables_
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_..._
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_by_
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_conf.level_
ard_survey_continuous_ci 👶 $+0.01$ ard_survey_continuous_ci_data_
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_errors_are_captured
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_method_by_
ard_survey_continuous_ci 👶 $+0.00$ ard_survey_continuous_ci_method_variables_
ard_survey_continuous_ci 👶 $+0.01$ ard_survey_continuous_ci_variables_

Results for commit 772121f

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 28, 2024

badge

Code Coverage Summary

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R                     78       8  89.74%   39-44, 94, 97
R/ard_attributes.survey.design.R           2       0  100.00%
R/ard_car_anova.R                         45       2  95.56%   62, 65
R/ard_car_vif.R                           61       2  96.72%   52, 86
R/ard_continuous.survey.design.R         194       2  98.97%   172, 182
R/ard_effectsize_cohens_d.R              102       2  98.04%   68, 121
R/ard_effectsize_hedges_g.R               90       2  97.78%   68, 120
R/ard_emmeans_mean_difference.R           70       0  100.00%
R/ard_proportion_ci.R                     90       5  94.44%   115-119
R/ard_regression_basic.R                  16       1  93.75%   46
R/ard_regression.R                        51       0  100.00%
R/ard_smd_smd.R                           68       5  92.65%   58, 84-87
R/ard_stats_anova.R                       95       0  100.00%
R/ard_stats_aov.R                         36       0  100.00%
R/ard_stats_chisq_test.R                  39       1  97.44%   39
R/ard_stats_fisher_test.R                 42       1  97.62%   42
R/ard_stats_kruskal_test.R                35       1  97.14%   38
R/ard_stats_mcnemar_test.R                79       2  97.47%   63, 105
R/ard_stats_mood_test.R                   48       1  97.92%   46
R/ard_stats_oneway_test.R                 38       0  100.00%
R/ard_stats_prop_test.R                   84       1  98.81%   43
R/ard_stats_t_test_onesample.R            40       0  100.00%
R/ard_stats_t_test.R                     111       2  98.20%   65, 111
R/ard_stats_wilcox_test_onesample.R       41       0  100.00%
R/ard_stats_wilcox_test.R                 98       2  97.96%   65, 117
R/ard_survey_categorical_ci.R            116       1  99.14%   162
R/ard_survey_continuous_ci.R             136       4  97.06%   55-57, 206
R/ard_survey_svychisq.R                   37       1  97.30%   44
R/ard_survey_svyranktest.R                51       0  100.00%
R/ard_survey_svyttest.R                   50       0  100.00%
R/ard_survival_survdiff.R                 89       0  100.00%
R/ard_survival_survfit_diff.R             76       8  89.47%   31-34, 43-46
R/ard_survival_survfit.R                 174      13  92.53%   79-81, 85, 95-97, 128-132, 237
R/construction_helpers.R                  68      11  83.82%   154, 166-170, 196-200
R/proportion_ci.R                        195      28  85.64%   290, 293, 302-307, 315, 330, 438-461
TOTAL                                   2645     106  95.99%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/ard_survey_categorical_ci.R     +116      +1  +99.14%
R/ard_survey_continuous_ci.R      +136      +4  +97.06%
TOTAL                             +252      +5  +0.21%

Results for commit: 8cef7d5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@ddsjoberg ddsjoberg merged commit 635b6dc into main Jun 28, 2024
33 checks passed
@ddsjoberg ddsjoberg deleted the svy-onesample_ci branch June 28, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant