Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize action #1

Merged
merged 37 commits into from
Apr 25, 2024
Merged

Initialize action #1

merged 37 commits into from
Apr 25, 2024

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Apr 15, 2024

action.yaml Outdated Show resolved Hide resolved
script.R Outdated Show resolved Hide resolved
@pawelru
Copy link
Contributor

pawelru commented Apr 18, 2024

I'm sorry to say but this is extremely slow.
The first experiments on tern (quite heavy package with just a few revdeps) keeps timing out at 1h runtime of the script-execution time. This includes ~20mins on installing required packages (we can potentially cache it). The remaining time is consumed by revdep itself (plus our overhead but this is minimal - just a prints for now). We were able to check just 3 out of 5 revdeps whereas locally everything (!) completes under 10 mins!
I think that it's because GHA does not support parallelization implemented there. The only parameter we can control is num_workers. When set to 4 then it just hangs. Then I experimented with 1 and 2 value but cannot really see the difference. I came into a conclusion that this is simply not used from within GHA.
How this is being implemented? revdep is creating multiple processes in the background and do a infinite loop pinging its statuses. You can check it here

Let's try to cache required libs and see the difference but currently I have bad feelings about it...

@walkowif walkowif marked this pull request as ready for review April 25, 2024 11:59
@walkowif walkowif requested a review from cicdguy April 25, 2024 12:00
Copy link

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the short tagging workflow?

@walkowif
Copy link
Contributor Author

Can we also add the short tagging workflow?

Yes, I believe it's there (but I placed it in a wrong directory, now it should be fine).

script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
@walkowif walkowif merged commit dd285cd into main Apr 25, 2024
3 checks passed
@walkowif walkowif deleted the initialize-action branch April 25, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants