Convert rstan to a suggests to avoid windows installation issues #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
Hey @nociale / @wolbersm , Would you mind testing this out to see if it works for you. Essentially I've removed rstan from the imports and moved it to the suggests. This way rstan isn't installed by default with the package however the package errors if you try to use
method_bayes
and rstan isn't installed.The model is now compiled on the fly. Storing the compiled model is non-trivial though, for ease of programming I've currently just left it to the rstan default behaviour which is to store it in the session directory; this means the model will need to be recompiled once per session. If this is considered too much I could try writing it to the users home directory (or offering an option for the user to specify where to cache the model?) but my gut feeling was this is a suitable compromise.